@mattab opened this Issue on October 16th 2015 Member

follows up https://github.com/piwik/piwik/pull/9012 Dialogs implemented with angular will not display on reload or via URL

TODO:

  • Add some angular tests for angular dialog service.
  • Maybe add a UI test for the service w/ a dummy dialog directive.
@tsteur commented on October 16th 2015 Member

Does it make sense to use angular tests for this? A ui test sounds more appropriate but am not into it what the problem was

@diosmosis commented on October 16th 2015 Member

I just want to add complete coverage without adding too many ui tests.

@tsteur commented on October 17th 2015 Member

Just wondering how you make sure it's displayed? Check for a certain css class? Is it possible to trigger a reload of a page in the tests? Cause I thought angular tests are supposed to be unit tests, so curious if that's possible.

@diosmosis commented on October 17th 2015 Member

I haven't really thought about it. To clarify, I don't want to add 0 UI tests, just one or two UI tests, and then get full coverage via an angular test (instead of adding 10 extra UI tests or something).

@tsteur commented on October 17th 2015 Member

:+1: sounds good :) I only read the issue description and what was wondering about it

Powered by GitHub Issue Mirror