New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on currently loaded left menu item when current URL is full angular hash path + query, destroys graphs #9018
Comments
Ideally, clicking on the current sub-menu, will reload and display the same report again. This was implemented in 3.0.0 in #8319 and would be nice to have in 2.15.0 |
This bug only occurs in this case, how did you reach this case via the UI? Or did you manually change the URL? in either case, maybe this is not a "Must fix" if user cannot reach this state 'naturally'. what do you think? |
This bug only occurs in this case, how did you reach this case via the UI? Or did you manually change the URL? in second case, maybe this is not a "Must fix" if user cannot reach this state 'naturally'. what do you think? |
Manually changed the URL. Only reason it doesn't appear is because menu.twig sets URLs to
I fixed it in a PR already. |
Which PR was it @diosmosis ? issue can be reproduced on demo2: |
I cannot reproduce on demo2, do you have steps to reproduce? |
EDIT: after a recent PR the steps have changed:
|
Different bug, but same effect. |
As title.
To reproduce:
Note that the URL contains
#/?
which does not normally happen since menu URLs are defined as#...
or#?...
.Visitors > Overview
.The result is:
Cause
This is caused by https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/menu.js#L24.
When the hash is the same as what is loaded by angular, the browser does nothing. But the event above, triggers this event handler: https://github.com/piwik/piwik/blob/master/plugins/CoreVisualizations/javascripts/jqplot.js#L388 which destroys all visible plots.
The text was updated successfully, but these errors were encountered: