Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More numberformats #9016

Merged
merged 4 commits into from Oct 16, 2015
Merged

More numberformats #9016

merged 4 commits into from Oct 16, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 15, 2015

fixes #8970

  • Add formatting to the "revenue" column in All Websites dashboard
  • Add formatting to HTML email reports

Note: in PDF and HTML reports the revenue columns are not yet formatted.

@sgiehl sgiehl force-pushed the more_numberformats branch 2 times, most recently from ba8d0ec to f0f6979 Compare October 15, 2015 20:04
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 16, 2015
@mattab mattab added this to the 2.15.0 milestone Oct 16, 2015
mattab pushed a commit that referenced this pull request Oct 16, 2015
@mattab mattab merged commit 60bd87f into master Oct 16, 2015
@mattab mattab deleted the more_numberformats branch October 16, 2015 00:16
@mattab
Copy link
Member

mattab commented Oct 16, 2015

Nice one to have before 2.15.0!

@tsteur
Copy link
Member

tsteur commented Oct 16, 2015

If possible it would be nice to not add any more number formats to 2.15. It'll take me a couple of hours each time to apply similar changes in 3.0 as everything works differently there. Fixing number formatting in goals will already take me couple of hours :)

@tsteur
Copy link
Member

tsteur commented Oct 16, 2015

It might be fine if they affect only API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants