Dialogs implemented with angular will not display on reload or via URL #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loading page w/ angular dialog via URL will work.
diosmosis
added
Pull Request WIP
|
let me know when this can be merged and we'll cut a new RC |
mattab
pushed a commit
that referenced
this pull request
Oct 16, 2015
Dialogs implemented with angular will not display on reload or via URL
|
Follow up issue: #9023 |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an angular dialog is loaded by URL (ie, if the URL contains popover=... and it wasn't modified via JS, but was loaded directly), the dialog will not display.
This PR fixes this. Should not be merged w/o tests, though.
TODO: