Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site selectors are not rendered correctly in dialogs #9010

Merged
merged 1 commit into from Oct 15, 2015

Conversation

diosmosis
Copy link
Member

As title. Due to .borderedControl CSS only being applied to children of #root. This change applies the CSS to .ui-dialog + .ngdialog elements as well. Not sure if there is a better approach as I am not too familiar w/ the top control / left menu changes.

…so controls like site selector can be more easily displayed in dialogs.
@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 15, 2015
@diosmosis diosmosis added this to the 2.15.0 milestone Oct 15, 2015
mattab pushed a commit that referenced this pull request Oct 15, 2015
Site selectors are not rendered correctly in dialogs
@mattab mattab merged commit d40610e into master Oct 15, 2015
@mattab mattab deleted the bordered_control_dialogs branch October 15, 2015 23:25
@mattab
Copy link
Member

mattab commented Oct 15, 2015

problem could be seen in UI tests for InterSites plugin: https://travis-ci.org/PiwikPRO/plugin-InterSites/jobs/85543256 against 2.15.0-rc1

@mattab
Copy link
Member

mattab commented Oct 16, 2015

@diosmosis this seems to have regressed where the calendar selector now has grey background http://builds-artifacts.piwik.org/piwik/piwik/master/16260/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants