Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on menu expands the sub-menu, but do not load first sub-menu page #9007

Closed
mattab opened this issue Oct 15, 2015 · 9 comments
Closed
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 15, 2015

Changes suggested:

  • click on menu item: toggle the submenu (expand/collapse)
  • several submenus can be expanded at the same time

Advantages

  • avoid the display of possibly un-necessary information (flashing data, we try to avoid)
  • one can view the whole structure of reports submenus at once (by expanding reports)
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 15, 2015
@mattab mattab added this to the 2.15.0 milestone Oct 15, 2015
@tsteur
Copy link
Member

tsteur commented Oct 15, 2015

👎 "for several submenus can be expanded at the same time" and for "one can view the whole structure of reports submenus at once (by expanding reports)"

The more you click around on different reports over time all categories will be opened and you'll have to scroll a lot and it will be harder to find what you want etc. Then you could directly leave all menus open from the beginning as it is in Admin / User area. After clicking on a view reports it'll look like this:

image

I'd be kinda okay with click on menu item expands the submenu but then it should also close the other one.

If we should still do the expanding of all menus we kinda have to show scrollbars in the menu and make it scrollable similar to GA. Otherwise it will be unusable. Especially on mobile devices it would involve a lot of scrolling

@mattab
Copy link
Member Author

mattab commented Oct 15, 2015

with click on menu item expands the submenu but then it should also close the other one.

Ok let's do it with "close the other one" to keep things tidy and avoid the extra-scroll

@quba
Copy link
Contributor

quba commented Oct 15, 2015

What about the option to temporary hide left menu and search bar?

@tsteur
Copy link
Member

tsteur commented Oct 15, 2015

You mean kinda zen mode? That would be a different feature, wouldn't it?

@quba
Copy link
Contributor

quba commented Oct 15, 2015

Just hide/show like in GA. And yes - it's a different feature. :)

@tsteur
Copy link
Member

tsteur commented Oct 15, 2015

Yep could be done with a bit of work. Once quickly tried to implement it but would need a couple of changes, suggested it here (ZenMode): #8936

I'd leave the search bar enabled and only hide the actual menu so one can still change between reports, to another menu item and to other segments, websites, ... without having to enable the left menu

@tassoman
Copy link
Contributor

tassoman commented Nov 5, 2015

@tsteur where did you binded menuitem's onclick behavior? I'm interested because I would like to work on it for better a11y improvements.

@tsteur
Copy link
Member

tsteur commented Nov 5, 2015

I haven't really changed anything here. I think it is this one here: https://github.com/piwik/piwik/blob/2.15.0/plugins/CoreHome/javascripts/menu.js#L101

In Piwik 3.0 they are normal links via href if I remember correctly, I presume that will be better?

@tassoman
Copy link
Contributor

tassoman commented Nov 6, 2015

In general we should try to avoid "no were going" a href="" empty attributes.
In this case I've dived inside js/jquery menu script too and I found click() method were used. Sadly this method excludes focus event that are triggered by keyboard.
So that I've briefly googled the web and I've found something written about it: Keyboard Accessibility with Javascript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

4 participants