New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click on menu expands the sub-menu, but do not load first sub-menu page #9007
Comments
👎 "for several submenus can be expanded at the same time" and for "one can view the whole structure of reports submenus at once (by expanding reports)" The more you click around on different reports over time all categories will be opened and you'll have to scroll a lot and it will be harder to find what you want etc. Then you could directly leave all menus open from the beginning as it is in Admin / User area. After clicking on a view reports it'll look like this: I'd be kinda okay with click on menu item expands the submenu but then it should also close the other one. If we should still do the expanding of all menus we kinda have to show scrollbars in the menu and make it scrollable similar to GA. Otherwise it will be unusable. Especially on mobile devices it would involve a lot of scrolling |
Ok let's do it with "close the other one" to keep things tidy and avoid the extra-scroll |
What about the option to temporary hide left menu and search bar? |
You mean kinda zen mode? That would be a different feature, wouldn't it? |
Just hide/show like in GA. And yes - it's a different feature. :) |
Yep could be done with a bit of work. Once quickly tried to implement it but would need a couple of changes, suggested it here (ZenMode): #8936 I'd leave the search bar enabled and only hide the actual menu so one can still change between reports, to another menu item and to other segments, websites, ... without having to enable the left menu |
@tsteur where did you binded menuitem's onclick behavior? I'm interested because I would like to work on it for better a11y improvements. |
I haven't really changed anything here. I think it is this one here: https://github.com/piwik/piwik/blob/2.15.0/plugins/CoreHome/javascripts/menu.js#L101 In Piwik 3.0 they are normal links via |
In general we should try to avoid "no were going" a href="" empty attributes. |
Changes suggested:
Advantages
The text was updated successfully, but these errors were encountered: