Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White icons in Manage Goals #9005

Closed
mattab opened this issue Oct 15, 2015 · 5 comments
Closed

White icons in Manage Goals #9005

mattab opened this issue Oct 15, 2015 · 5 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 15, 2015

In Manage Goals, white icons. Expected: dark icons.

white icons

Our screenshot tests should have maybe caught this bug? or maybe it's caused by another plugin

@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 15, 2015
@mattab mattab added this to the 2.15.0 milestone Oct 15, 2015
@tsteur
Copy link
Member

tsteur commented Oct 15, 2015

Cannot reproduce this one. Maybe caused by another plugin?

@quba
Copy link
Contributor

quba commented Oct 15, 2015

You can reproduce this on demo2

@tsteur
Copy link
Member

tsteur commented Oct 15, 2015

Yes, but must be still caused by a plugin. Don't wanna disable any plugins there to find out. Leaving this to @mattab as I'm not aware of any possible side effects

@mattab
Copy link
Member Author

mattab commented Oct 15, 2015

Fyi: this is caused by WhiteLabel plugin https://github.com/PiwikPRO/plugin-WhiteLabel/blob/master/Config.php#L170-L176 - the " Button Text Color " is applied to icons but this color shouldn't apply to icons

@tsteur
Copy link
Member

tsteur commented Oct 16, 2015

Shall we move the issue to the whitelabel plugin then? The workflow is to not release a new version of the plugin before the actual core release anyway

@mattab mattab closed this as completed Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

3 participants