Only add piwik-expand-on-click to the controls that need it #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
not-in-changelog
tsteur
added a commit
that referenced
this pull request
Oct 14, 2015
Only add piwik-expand-on-click to the controls that need it
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8993
This is needed for #8993 . Otherwise the comparison dashboard, which is a UI control that contains other UI controls, gets a
piwik-expand-on-clickas well which results in selectors that do not open. Eg segment selector used to have thispiwik-expand-on-clickas well which is responsible to expand the dropdown when clicking on it. This would work but the comparison dashboard would do the same and close it immediately again.Also for various other reasons I had to remove
piwik-expand-on-clickfrom SegmentSelector as it otherwise did not behave correctly anymore. The only side effect will be that pressingescapewon't close it anymore.Everything should work as before otherwise.