Add CloudFlare location provider #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I don't think we want to add CloudFlare support since it only reports the "Country" which is too limited. I would recommend CF users to setup Maxmind for better accuracy. |
|
I get that it's not as accurate as GeoIP, but it's still a good deal better than the default 'browser language' provider. |
This was referenced Jun 17, 2009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This pull request adds a CloudFlare location provider to the UserCountry plugin.
If Piwik is behind a CloudFlare proxy, all requests have a HTTP_CF_IPCOUNTRY header containing the country code of the visitor as looked up by CloudFlare. This LocationProvider simply uses that value.
I am not sure how to get things set up for internationalization or what your requirements are on that front, so I have just hardcoded English strings for now. If you let me know what needs to be done, I will do it.