Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left menu tweaks #8974

Merged
merged 4 commits into from Oct 13, 2015
Merged

Left menu tweaks #8974

merged 4 commits into from Oct 13, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 12, 2015

  • prevent flicker of menu category when there is no menu item for that category. Remove this item server side now instead of client side
  • construct search tooltip depending on available selectors eg title will change depending whether segment selector and website selector is available
  • show top controls only after all are most likely rendered. I cannot guarantee the detection always works and that it doesn't have any side effects. In worst case it wouldn't show the top controls at all but it should not happen.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 12, 2015
@tsteur tsteur added this to the 2.15.0 milestone Oct 12, 2015
mattab pushed a commit that referenced this pull request Oct 13, 2015
@mattab mattab merged commit 08c7e26 into master Oct 13, 2015
@mattab mattab deleted the left_menu_tweaks branch October 13, 2015 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants