Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Last seen" human readable #8956

Closed
gaumondp opened this issue Oct 9, 2015 · 7 comments
Closed

Make "Last seen" human readable #8956

gaumondp opened this issue Oct 9, 2015 · 7 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@gaumondp
Copy link

gaumondp commented Oct 9, 2015

Administration => Users => User Management

The "Last seen" column is in : HH:MM:SS and reading 6340:45:23 for example, is not really human-friendly. Maybe when hours > 24 then use DD day(s):HH:MM:SS.

Another option would be to just show the date of last login? date("D M j G:i:s T Y"); ?

I don't think #8857 (Improve number formats) takes care of this one as far as I can see.
@sgiehl
Copy link
Member

sgiehl commented Oct 9, 2015

#8857 doesn't care that yet. It might be done in a later step. But I'm not sure if it will make it in 2.15

@ritvikgautam
Copy link
Contributor

This would be an interesting thing to do for a beginner like me.
Enough with using piwik, I'd be glad to contribute.

@gaumondp
Copy link
Author

@ritvikgautam I'll do cheerleading for you. ;)

Seriously I would try the patch if you provide some.

@ritvikgautam
Copy link
Contributor

Thanks!
Could you give me a hint as to which files I should look into for this?

@sgiehl
Copy link
Member

sgiehl commented Oct 28, 2015

https://github.com/piwik/piwik/blob/master/plugins/UsersManager/Controller.php#L112-L114

@ritvikgautam ritvikgautam mentioned this issue Oct 28, 2015
Merged
@ritvikgautam
Copy link
Contributor

I've created a pull request. Please have a look at #9112
@gaumondp

@mattab
Copy link
Member

mattab commented Dec 23, 2015

done in #9112 - cheers @ritvikgautam

@mattab mattab closed this as completed Dec 23, 2015
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattab @sgiehl @ritvikgautam @gaumondp