Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left menu design follow up #8940

Closed
4 tasks done
mattab opened this issue Oct 7, 2015 · 3 comments
Closed
4 tasks done

Left menu design follow up #8940

mattab opened this issue Oct 7, 2015 · 3 comments
Assignees
@tsteur
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Oct 7, 2015

Follows up #8936

overlap

  • Bug, reproduce: open the real time map page, change the website, the language selector will appear expanded for 1 or 2 seconds and then will collapse. reproduced in Firefox. it looks like this for 1 second or so:

selector expanded
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 7, 2015
@mattab mattab added this to the 2.15.0 milestone Oct 7, 2015
@mattab
Copy link
Member Author

mattab commented Oct 8, 2015

  • Just tested on an iphone to click on the burger, it was quite difficult to click on the small icon. would it make sense to make the clickable area bigger, around the burger icon?

@tsteur
Copy link
Member

tsteur commented Oct 8, 2015

Just tested on an iphone to click on the burger, it was quite difficult to click on the small icon. would it make sense to make the clickable area bigger, around the burger icon?

That's what I mentioned recently in chat. Ideally all the icons would be bigger for mobile but that's rather an issue of improving mobile view than left menu. That's why I didn't invest even more time as it might be not as trivial.

UI tests: there is a empty white selector at top:

The selector was there before on the right. It's the update Piwik message that is hidden by default.

SiteSelector tests failed because they used UserSettingsPage which I fixed yesterday and test needed to be updated

@tsteur
Copy link
Member

tsteur commented Oct 8, 2015

Language selector was a very tough one to find out but should be fixed. (forgot to reference the commits they were 3146287 d07c12f 2c75ff0 )

@tsteur tsteur closed this as completed Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@tsteur @mattab