Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left menu #8936

Merged
merged 2 commits into from Oct 7, 2015
Merged

Left menu #8936

merged 2 commits into from Oct 7, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 7, 2015

fixes #7589 #7588 #7169

  • Left menu which is supposed to be more clear and simple. The content itself pretty much stays the same, we want to remove attention from the menus and header etc and let users focus on content
  • Better layout for mobile devices
  • Includes a fix for UI testing framework where a click was not executed when the element to click is not visible in the viewport
  • Includes a new search to search for current menu items, websites and segments (can be activated via shortcut f)
  • Unified selectors eg they can be all closed by pressing escape now, they are pretty much always displayed in the top etc
  • Many other bugfixes that I noticed while working on it
  • Removed a lot of CSS that was duplicated before etc
  • Zen Mode was removed as it was supposed to remove the space it needs in the header, as the header doesn't need much space anymore it is no longer needed. We might introduce a ZenMode later at some point which will be eg activated by pressing the key z which will fade out the left menu to have full width content. The left menu is not really needed anymore when using search
  • Left Menu plugin was removed as left menu is enabled by default now. There is no way to get back the top menu

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 7, 2015
@tsteur tsteur added this to the 2.15.0 milestone Oct 7, 2015
mattab pushed a commit that referenced this pull request Oct 7, 2015
@mattab mattab merged commit 12e3708 into master Oct 7, 2015
@mattab
Copy link
Member

mattab commented Oct 7, 2015

well done @tsteur for epic Pull request. 🚀

Waiting for UI tests and make build green. If any regression, i'll create separate issues.

So exciting that we get left menu & clean simple UI for Piwik 2.15.0!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants