Always show apply button in date selector #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Looks like there's a UI test failure that shouldn't fail: http://builds-artifacts.piwik.org/piwik/piwik/8864/15965/UIIntegrationTest_period_select_date_range_click Otherwise looks good. |
|
UI test should be fixed. Had to update the test itself after some trial and error |
tsteur
added a commit
that referenced
this pull request
Oct 7, 2015
Always show apply button in date selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8864
Looks like this:
The right side of the selector does now take more space which looks maybe a bit weird. I'd suggest to increase the font size of the data selectors from 10px to 11px or 12px and the font size of each date in the calendar view from 11px to 12px. Then they are about even and it will be easier to select a date since they are tiny :)