Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment editor ui tests #8921

Merged
merged 2 commits into from Oct 5, 2015
Merged

Segment editor ui tests #8921

merged 2 commits into from Oct 5, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Oct 5, 2015

Last night I overwrote the UI tests a bit too quickly in: https://github.com/piwik/piwik-ui-tests/commit/acb60ce853ad04fcc6e58436173497cbf39eee70

some of the UI tests regressed so this PR fixes it to make sure our UI tests still test what they're supposed to

mattab pushed a commit that referenced this pull request Oct 5, 2015
Merge pull request #8921 from piwik/segment_editor_ui_tests
1e55077 
Segment editor ui tests
@mattab mattab merged commit 1e55077 into master Oct 5, 2015
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 5, 2015
@mattab mattab deleted the segment_editor_ui_tests branch October 5, 2015 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattab