Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure plugin environment files are loaded after the base environment config file instead of before w/ the plugin config.php. #8907

Merged
merged 1 commit into from Oct 4, 2015
Merged

Make sure plugin environment files are loaded after the base environment config file instead of before w/ the plugin config.php. #8907

merged 1 commit into from Oct 4, 2015

Conversation

diosmosis
Copy link
Member

Doing it the old way causes plugin environment specifc config to be unset by the core environment config (eg, a plugins' test.php will have no effect, because core/config/test.php ends up overriding it).

Make sure plugin environment files are loaded after the base environm…
1c0f6d8 
…ent config file instead of before w/ the plugin config.php.

Doing it the old way causes plugin environment specifc config to be unset by the core environment config (eg, a plugins' test.php will have no effect, because core/config/test.php ends up overriding it).
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Oct 4, 2015
@diosmosis diosmosis added this to the 2.15.0 milestone Oct 4, 2015
diosmosis added a commit that referenced this pull request Oct 4, 2015
@diosmosis
Merge pull request #8907 from piwik/container_config_priority
d6fc03d 
Make sure plugin environment files are loaded after the base environment config file instead of before w/ the plugin's config.php file.
@diosmosis diosmosis merged commit d6fc03d into master Oct 4, 2015
@diosmosis diosmosis deleted the container_config_priority branch October 4, 2015 13:45
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab