Regression: columns query parameter is never urldecoded in PHP so it cannot be encoded in JS. #8905
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cannot be encoded in JS.
diosmosis
added
not-in-changelog
diosmosis
added a commit
that referenced
this pull request
Oct 4, 2015
Regression: columns query parameter is never urldecoded in PHP so it cannot be encoded in JS.
diosmosis
pushed a commit
that referenced
this pull request
Oct 4, 2015
| @@ -67,7 +67,12 @@ | |||
| searchObject[name] = searchObject[name][searchObject[name].length - 1]; | |||
| } | |||
|
|
|||
| searchString.push(name + '=' + encodeURIComponent(searchObject[name])); | |||
| var value = searchObject[name]; | |||
| if (name != 'columns') { // the columns query parameter is not urldecoded in PHP code. TODO: this should be fixed in 3.0 | |||
There was a problem hiding this comment.
@diosmosis maybe you can create follow up issue for 3.0.0 and, ideally, a pull request while this is fresh in your mind? :-)
There was a problem hiding this comment.
Won't master be merged w/ 3.0?
There was a problem hiding this comment.
Yes it will be merged, after this merge we need to remove this TODO, that's hwy we need an issue for this or we will forget and not do it
There was a problem hiding this comment.
Actually, that comment is incorrect, something is double encoding it, I'll have to take another look.
There was a problem hiding this comment.
Created an issue: #8928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
&columns=query parameter is supplied in the URL fragment thehistoryangular service will encode the parameter. In PHP, however, Piwik will never decode the parameter, so values like:nb_visits%2Cnb_actionswill be interpreted incorrectly.
We can't change
Common::getRequestVarto url decode for 2.15 in order to maintain BC, so this change makes sure columns is not url encoded when being detected in the history service.