Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking too fast can result in nothingness #8894

Merged
merged 1 commit into from Oct 3, 2015
Merged

Clicking too fast can result in nothingness #8894

merged 1 commit into from Oct 3, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 2, 2015

fixes #8845 #8319

FYI: We cannot use $location.hash(); here as it would not return anything. The hash would be in this case after '#?this=is&search=true#thisIshash'. $location.search returns an object and cannot be used for such a comparison.

BTW: This is fixed in 3.0 branch already

@tsteur
Clicking too fast can result in nothingness
1b56e7a 
fixes #8845 #8319

FYI: We cannot use `$location.hash();` here as it would not return anything. The hash would be in this case after '#?this=is&search=true#thisIshash'. `$location.search` returns an object and cannot be used for such a comparison.

BTW: This is fixed in 3.0 branch already
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 2, 2015
@tsteur tsteur added this to the 2.15.0 milestone Oct 2, 2015
@sgiehl
Copy link
Member

sgiehl commented Oct 3, 2015

👍

sgiehl added a commit that referenced this pull request Oct 3, 2015
@sgiehl
Merge pull request #8894 from piwik/8845
ed29aaa 
Clicking too fast can result in nothingness
@sgiehl sgiehl merged commit ed29aaa into master Oct 3, 2015
@sgiehl sgiehl deleted the 8845 branch October 3, 2015 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl