Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment subquery cache: minor code review items #8892

Merged
merged 3 commits into from Oct 4, 2015
Merged

Segment subquery cache: minor code review items #8892

merged 3 commits into from Oct 4, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Oct 1, 2015

follows up: #8850

Todo

  • Put class in DI, and dependencies too

@mattab mattab added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 1, 2015
@mattab mattab self-assigned this Oct 1, 2015
@mattab mattab added this to the 2.15.0 milestone Oct 1, 2015
@mattab mattab mentioned this pull request Oct 1, 2015
Closed
@mattab mattab changed the title minor code review items Segment subquery cache: minor code review items Oct 1, 2015
mattab pushed a commit that referenced this pull request Oct 4, 2015
Merge pull request #8892 from piwik/remove_lazy_flush
c435b26 
Segment subquery cache: minor code review items
@mattab mattab merged commit c435b26 into master Oct 4, 2015
@mattab mattab deleted the remove_lazy_flush branch October 4, 2015 23:43
@mattab
Copy link
Member Author

mattab commented Oct 5, 2015

This change is not complete. If TableLogAction/Cache is stored in the DI container, you do not need to use Config::getInstance() or StaticContainer.

Oh ok! I just understand this. Thanks, will create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattab mattab

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @diosmosis