Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to plugin details didn't work #8877

Merged
merged 1 commit into from Oct 1, 2015
Merged

Links to plugin details didn't work #8877

merged 1 commit into from Oct 1, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 30, 2015

fixes #8863

Several links to plugin details in plugin list or plugin update notifications didn't work.
Now all links providing the data attribute pluginName and having the class plugin-details will automatically be linked to the related details.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 30, 2015
@sgiehl sgiehl added this to the 2.15.0 milestone Sep 30, 2015
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Sep 30, 2015
mattab pushed a commit that referenced this pull request Oct 1, 2015
Merge pull request #8877 from piwik/plugin_links
254bf89 
Links to plugin details didn't work
@mattab mattab merged commit 254bf89 into master Oct 1, 2015
@mattab
Copy link
Member

mattab commented Oct 1, 2015

👍

@mattab mattab deleted the plugin_links branch October 2, 2015 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab