fixes: popovers might clear page content #8876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
added
the
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Oct 1, 2015
fixes: popovers might clear page content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the popovers in administration of Piwik (e.g. plugin popover in marketplace) might clear the original page content when opening or closing it.
That is due to a "fix" for angularjs (See https://github.com/piwik/piwik/blob/master/plugins/CoreHome/angularjs/history/history.service.js#L91-L95)
Opening and closing a popover triggers a hash change, which clears the content to replace it with new one if the hash is present.
With this small change the param added to fix angularjs is ignored for loading pages.