New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows integration test fixes #8849
Conversation
Current result:
|
The latest commit should fix the The other integration tests fail due to a mysql issue, which i need to check... @mattab feel free to review/merge, when the build is green 👍 |
@@ -34,7 +34,10 @@ public function setUp() | |||
|
|||
public function tearDown() | |||
{ | |||
$this->output->destroy(); | |||
if(is_object($this->output)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall i remove this?
windows integration test fixes
Nice PR, looks good @ThaDafinser |
This is a PR to fix the Integration tests. UnitTests should be fine already.