Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNT ignore for Epiphany #8838

Merged
merged 1 commit into from Sep 24, 2015
Merged

DNT ignore for Epiphany #8838

merged 1 commit into from Sep 24, 2015

Conversation

ThaDafinser
Copy link
Contributor

@ThaDafinser
Copy link
Contributor Author

I dont like the current check, since it's directly in the code and it's not version specific.

Would this be maybe a good idea to move this job to the device-detector library? https://github.com/piwik/device-detector

ping @sgiehl

@sgiehl
Copy link
Member

sgiehl commented Sep 22, 2015

Not sure if moving it to device detector makes it much better... Regardless where it's done we need to maintain a list with the browsers that should be handled special...

@tsteur
Copy link
Member

tsteur commented Sep 23, 2015

Can we merge this one and create a new issue for how to maintain that list? @sgiehl

@sgiehl
Copy link
Member

sgiehl commented Sep 23, 2015 via email

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 24, 2015
@tsteur
Copy link
Member

tsteur commented Sep 24, 2015

@ThaDafinser feel free to create issues for your suggestion. We can possibly move the definition to a DI config outside the code so plugins could extend it as well.

Defining a min version for browsers would be nice too and fair for the users to respect their privacy.

tsteur added a commit that referenced this pull request Sep 24, 2015
@tsteur tsteur merged commit 7d6e24b into matomo-org:master Sep 24, 2015
@tsteur
Copy link
Member

tsteur commented Sep 24, 2015

Thx for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants