Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 'Provider' plugin by default for new Piwik users (tracker performance) #8826

Closed
mattab opened this issue Sep 20, 2015 · 4 comments
Closed

Disable 'Provider' plugin by default for new Piwik users (tracker performance) #8826

mattab opened this issue Sep 20, 2015 · 4 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Sep 20, 2015

Currently, Provider plugin is enabled by default in Piwik.

In Piwik 3.0.0 we aim to move this plugin to the Marketplace in #5341.

In the meantime, since Provider plugin can negatively affect Tracking API performance see #8785, since the value provided by the plugin is small, I suggest we do not enable the plugin by default for new users. This will be good for user experience, tracking speed, and minimising support in LTS.
@mattab mattab added this to the 2.15.0 milestone Sep 20, 2015
mattab added a commit that referenced this issue Sep 20, 2015
@mattab
Do not enable Provider plugin by default for new users fixes #8826
1e315f1
This was referenced Sep 20, 2015
Merged
Closed
diosmosis added a commit that referenced this issue Sep 20, 2015
@diosmosis
Merge pull request #8827 from piwik/8826_disable_provider
fd30eed 
Fixes #8826, Do not enable Provider plugin by default for new users
@mattab
Copy link
Member Author

mattab commented Sep 20, 2015

#8827 was reverted but is not yet re-opened

@mattab mattab reopened this Sep 20, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Sep 20, 2015
mattab added a commit that referenced this issue Sep 21, 2015
@mattab
Make Provider plugin disabled by default. fixes #8826
627cc82
@mattab mattab mentioned this issue Sep 21, 2015
Merged
@mattab mattab added the c: Performance For when we could improve the performance / speed of Matomo. label Oct 13, 2015
@mattab mattab changed the title Disable 'Provider' plugin by default for new Piwik users Disable 'Provider' plugin by default for new Piwik users (tracker performance) Oct 13, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 13, 2015
@MagicFab
Copy link

While reading this it occurred to me some method of caching such information could be implemented later on (unless that's already the case), just writing it here to not forget it.

@MagicFab
Copy link

MagicFab commented Feb 1, 2016

This also means for anyone upgrading from a previous version Provider data will not be tracked / kept until the Provider plugin is re-activated.

TL;DR: If you're upgrading from <2.15 and Provider data is important to you, verify the plugin is re-activated properly as part of the upgrade procedure.

@mattab
Copy link
Member Author

mattab commented Feb 1, 2016

@MagicFab the Provider plugin is not disabled on Update, only "not enabled for users installing Piwik new"

pfleckenbw added a commit to pfleckenbw/Piwik-IntranetGeoIP that referenced this issue Oct 14, 2016
@pfleckenbw
disabled provider by default
e86846b 
As a result of Piwik-Issue 8826 (matomo-org/matomo#8826) the "Provider"-Plugin is disabled in Version 2.15 and above by default. As commented in Piwik-IntranetGeoIP-Issue-21 (ThaDafinser#21 (comment)) it would make sense, to comment out the location_provider-Field by default
pfleckenbw added a commit to pfleckenbw/Piwik-IntranetGeoIP that referenced this issue Oct 14, 2016
@pfleckenbw
disable provider by default
97c28d1 
As a result of Piwik-Issue 8826 (matomo-org/matomo#8826) the "Provider"-Plugin is disabled in Version 2.15 and above by default. As commented in Piwik-IntranetGeoIP-Issue-21 (ThaDafinser#21 (comment)) it would make sense, to comment out the location_provider-Field by default
@pfleckenbw pfleckenbw mentioned this issue Oct 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@MagicFab @mattab