Fix some icon placement issues #8817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2015 20:28
…ign middle since that only works for table cells).
diosmosis
added
not-in-changelog
|
Most icons seem to be misplaced now see eg http://builds-artifacts.piwik.org/piwik/piwik/8748_icon_placements/15467/ActionsDataTable_initial in http://builds-artifacts.piwik.org/piwik/piwik/8748_icon_placements/15467/ |
|
I pushed an update that should fix most of the misplaced icons, need to wait for UI tests. Another quick review might be needed afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Fixes #8748