Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When saving plugin settings, disable the "Save" button to prevent double clicks #8811

Closed
mattab opened this issue Sep 17, 2015 · 5 comments
Closed

When saving plugin settings, disable the "Save" button to prevent double clicks #8811

mattab opened this issue Sep 17, 2015 · 5 comments
Assignees
@tsteur
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Sep 17, 2015

When saving plugin settings, we should disable the "Save" button to prevent double clicks. Otherwise user may get Cloud not verify the security token on this form and believe the form submission failed.
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Sep 17, 2015
@mattab mattab added this to the 2.15.0 milestone Sep 17, 2015
@sgiehl
Copy link
Member

sgiehl commented Sep 17, 2015

I'd suggest to do that global for all save buttons (where needed) maybe with a special class or data attribute. Doesn't make sense to find a new solution for every new save button ;)

@mattab
Copy link
Member Author

mattab commented Sep 17, 2015

Definitely!

@mgonera
Copy link

mgonera commented Sep 17, 2015

screencast 2015-09-17 12-01-42

@diosmosis
Copy link
Member

This is what https://docs.angularjs.org/api/ng/directive/ngDisabled is for. Should use this instead of creating a non-angular solution. Though something that bridges jquery/angular will be needed for now.

@tsteur
Copy link
Member

tsteur commented Oct 2, 2015

We cannot really use ngDisabled here as there's not an angular component around this that unsets ngDisabled= once the request is done/failed. Ideally we would use it though I will see what is possible. Of course we can get the elements scope and reset it but that's a mess. Especially when multiple save buttons are registered in the root scope because they do not define their own scope.

tsteur added a commit that referenced this issue Oct 2, 2015
@tsteur
refs #8811 disable save button when clicking on it
d94331a
@tsteur tsteur self-assigned this Oct 2, 2015
@tsteur tsteur mentioned this issue Oct 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
5 participants
@diosmosis @tsteur @mattab @sgiehl @mgonera