Improving extendibility of Login plugin #8801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to matomo-org#8723 to improve extendibility of the Login plugin
|
That will teach me. It fails badly. Thanks for a heads-up Mr. Travis and Mrs. Scrutinizer. Someone was relying on those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8723 to improve extendibility of the Login plugin. This is not (currently) required for my own plugin, but others could profit from it - see e.g. torosian/LoginRevokable#2.
These are just the Login classes extended by my own and the above plugin. And none of the other Login plugins seems to extend any additional Login classes. So that I didn't do this improvement on other files of Login.