Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less installation #88

Merged
merged 31 commits into from Jul 13, 2013
Merged

Less installation #88

merged 31 commits into from Jul 13, 2013

Conversation

tzi
Copy link
Member

@tzi tzi commented Jul 13, 2013

Hi guys!

I continue my CSS cleanup: this time I installed Less.
So I changed the AssetManager.
The main modification is that the CSS are always merged, because we can't directly use the Less files.

I also changed the CSS dependency of the Login, Installation & CoreUpdater plugin pages.
The Login plugin use the same CSS files that the dashboard to allow theming.
Installation & CoreUpdater will use a base.css file, that are a compilation of a part of the Less files. The purpose is to prevent theming & to have less maintenance.

Finaly, I initiate the plugin PleineLune: a dark theme for Piwik.
I don't know if I did it the right way, but it allows me to activate it.

Cheers,
Thomas.

tzi added 30 commits July 9, 2013 17:14
@tzi
Initialisation of the PleineLune theme
572220f
@tzi
Add Less composer dependency
623cfba
@tzi
Use less to compile CSS files. CSS files are now always merged, even …
74ba840 
…in development platform
@tzi
Use the AssetManager constant to avoid typo
04663fa
@tzi
Change the extension to .less for CSS files that will be compiled
8177059
@tzi
Remove old vendor-prefix for border-radius
a7bef9c
@tzi
Regenerate the merged CSS every time in development
b3b911e
@tzi
Handle @import rule in less files
b4efa92
@tzi
Remove useless breaklines
5450396
@tzi
Improve admin theming
dd52460
@tzi
Add PleineLune for main navigation
c968527
@tzi
Migration of 'Add a site' button icon
12e5a90
@tzi
Merge branch 'master' of github.com:piwik/piwik into pleineLune__less…
f9d524a 
…-installation
@tzi
Simplify the page layout and theme it
e5c62f9
@tzi
Remove ie7 specific style
b75343f
@tzi
Add spaces between tabs
e616da0
@tzi
Remove logo inline style
ff44dc2
@tzi
Reorganize topBars styles & theme it
09c7e0c
@tzi
Merge branch 'master' of github.com:piwik/piwik into pleineLune__less…
2566d55 
…-installation
@tzi
Change the colors of the PleineLune theme
76e582d
@tzi
Improve the main nav menu on the tiny screen. There is still a lot to do
a093e74
@tzi
Handle tiny screen for main tab navigation
7146399
@tzi
Add translation for the plugin
59271fb
@tzi
Reorganize the dashboard with one column for the tiny screens
3514188
@tzi
Add all plugins CSS files, including theming, in login page
40f0575
@tzi
Initialize subMenu height when dom ready
e5e1a56
@tzi
Generate a base.css file from a base.less file for Installation & Cor…
a01582a 
…eUpdater plugin
@tzi
Separate styles.css & common.css on multiple meaningful files
606db61
@tzi
Format code & regenerate the base.css file
7e3a751
@tzi
Merge branch 'master' of github.com:piwik/piwik into pleineLune__less…
ae75d23 
…-installation
@mattab
Copy link
Member

mattab commented Jul 13, 2013

Great stuff! It's so useful to have such a broad cleanup of CSS and templates.

I did some quick testing and found a few regressions:

  • website selector pushes content down instead of on hover)
  • The language selector pushes content on click (visual bug)
  • language selector right arrow is too large
  • add display of site selector in "Email & SMS Reports"
  • Menu regressions:
    • I see the menu stays on the last menu that was focused. Often users focus menu by mistake or to learn, but stay in current screen. The menu should go back to the "Currently selected" menu on focus after abt couple seconds, after the mouse leaves the active focus zone.
  • Installation: the language selector appears at the top right out of the box

[edited]

I will look at the code in more details next couple days. Looking forward to the fixes of regressions and next PR. Enjoy your trip!

mattab pushed a commit that referenced this pull request Jul 13, 2013
Merge pull request #88 from tzi/pleineLune__less-installation
ea69cc4 
CSS, templates improvements. Enable Assetmanager on login page, separate css for installer/upgrader, progress in theming, Less installation. Super boulot Thomas !
@mattab mattab merged commit ea69cc4 into matomo-org:master Jul 13, 2013
@mattab
Copy link
Member

mattab commented Jul 13, 2013

the PleineLune theme works too, it will look so awesome with datatables and form elements are converted! 👍

@mattab mattab mentioned this pull request Oct 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tzi @mattab