Wrong place of CoreArchive.run.finish event #8795
Conversation
| * | ||
| * @param CronArchive $this | ||
| */ | ||
| Piwik::postEvent('CoreArchive.run.finish', array($this)); |
There was a problem hiding this comment.
I just realized those events (CoreArchive.run.start & CoreArchive.run.finish) were not placed within the run() method which is what they were supposed to be. Sorry I didn't notice they were placed in init() and end() method.
In this case we should rename CoreArchive.run.start into CoreArchive.init.start and CoreArchive.run.finish into CoreArchive.end I think?
As we haven't released a new version yet this should be no problem.
There was a problem hiding this comment.
Ok @tsteur I have just renamed mentioned events
Wrong place of CoreArchive.run.finish event
|
Thx! |
tsteur
added
the
not-in-changelog
|
Sorry I just noticed it is supposed to be |
Hi @mattab & @tsteur,
Do you remember about my latest PR which concerns the archiving lifecycle events: #8738
There is a small mistake, because the event
CoreArchive.run.finishwill execute only when we have some errors. In the other case it will never execute: https://github.com/andrzejewsky/piwik/blob/8d2ac648f6d222a8c4e2767b5fc4e7041bee68ea/core/CronArchive.php#L440This event should be placed at beginning of the
end()method.