Auto generated glossary of all Metrics & Report definitions in Piwik #8793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
the
Pull Request WIP
| { | ||
| Piwik::checkUserHasSomeViewAccess(); | ||
|
|
||
| $glossary = new Glossary($this->idSite); |
There was a problem hiding this comment.
I see this PR is still a work in progress, but I want to mention that classes that encapsulate application logic should be stateless or immutable service classes and should be obtained through DI. Instead of creating an instance of this type manually here, you should get it through StaticContainer.
To do this, you must:
- Remove the idSite as a constructor parameter and move to individual methods.
- Add constructor arguments for all dependencies in
Glossaryclass. Dependencies that aren't set via DI (ie, singletons that are not yet in DI) should be set in the constructor, but not as constructor arguments. (These I'll change manually when getting rid of Singleton/StaticContainer).
|
|
||
| namespace Piwik\Plugins\API; | ||
|
|
||
| class Glossary |
There was a problem hiding this comment.
Can you add tests for this class?
mattab
pushed a commit
that referenced
this pull request
Oct 2, 2015
Auto generated glossary of all Metrics & Report definitions in Piwik
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6773
Todo: