Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when loading dashboard a XHR request errors with Status=cancelled #8780

Closed
mattab opened this issue Sep 14, 2015 · 3 comments
Closed

when loading dashboard a XHR request errors with Status=cancelled #8780

mattab opened this issue Sep 14, 2015 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 14, 2015

Reproducible on demo.piwik.org - when loading dashboard, one xhr request is Status = (cancelled), and appears red in the developer tools network panel:

error loading a ajax request

Request that is "Aborted" is http://demo.piwik.org/index.php?date=2015-09-13&format=JSON2&idSite=7&method=SitesManager.getNumWebsitesToDisplayPerPage&module=API&period=day

-> Is this xhr request necessary? Maybe we could remove it to fix this issue (and slightly improve performance of dashboard page load)

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 14, 2015
@mattab mattab added this to the 2.15.0 milestone Sep 14, 2015
@diosmosis diosmosis self-assigned this Sep 15, 2015
@diosmosis
Copy link
Member

This was added in #8459 (a 2.15 PR). I think I can remove the API call.

@mattab Can you tell me if SitesManager.getNumWebsitesToDisplayPerPage needs to be exposed as an API method? If not, and it's not useful, I'll remove the API method.

@tsteur
Copy link
Member

tsteur commented Sep 21, 2015

The API method is useful but should be executed only once. We need to expose all such kinda data via API in the future

@diosmosis
Copy link
Member

FYI, I fixed the issue in a PR w/o removing the method, so the question isn't relevant now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants