Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-needed factory() #8779

Merged
merged 1 commit into from Sep 14, 2015
Merged

Remove un-needed factory() #8779

merged 1 commit into from Sep 14, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 14, 2015

class already extends BaseFactory with class name & error msg overrides

@mattab
Remove un-needed factory()
5bfb703 
class already extends BaseFactory with class name & error msg overrides
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 14, 2015
@mattab mattab added this to the 2.15.0 milestone Sep 14, 2015
mattab pushed a commit that referenced this pull request Sep 14, 2015
Merge pull request #8779 from piwik/smsprovider_remove_factory
b1820ed 
Remove un-needed factory()
@mattab mattab merged commit b1820ed into master Sep 14, 2015
@diosmosis diosmosis deleted the smsprovider_remove_factory branch September 14, 2015 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattab