Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row Evolution can fail when a segment is used #8776

Closed
mattab opened this issue Sep 14, 2015 · 4 comments
Closed

Row Evolution can fail when a segment is used #8776

mattab opened this issue Sep 14, 2015 · 4 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Sep 14, 2015

When a segment is used, opening row evolution and/or visitor profile does not work (in some cases)

Issue 1: row evolution

Reproduce:

Issue 2: visitor profile

I guess is the same issue:

Reproduce:

Suggested steps

  • Add UI test(s) to reproduce this issue (maybe we don't have a UI test for Row Evolution / Visitor profile with a segment set?)
  • Fix the issue

I didn't add Regression because this appears not to be a regression!
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 14, 2015
@mattab mattab added this to the 2.15.0 milestone Sep 14, 2015
@diosmosis
Copy link
Member

This is caused by https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/broadcast.js#L354. For some reason broadcast.getHashFromUrl encodes the URL again. This results in setting the new URL to something different from broadcast.currentHashUrl (after the popover= query param is removed), so broadcast.pageload will not load the popover (https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/broadcast.js#L119). Trying to figure out why...

@diosmosis diosmosis self-assigned this Sep 16, 2015
@diosmosis
Copy link
Member

Actually that's not quite right, it gets encoded again somewhere else...

@diosmosis
Copy link
Member

Caused by an angular bug, $location.absUrl() decodes url parameters (at least in the hash).

@diosmosis
Copy link
Member

Ok, not a bug with angular, it's because we use $location.path() to store hash query parameters. We should be using $location.search().

@diosmosis diosmosis mentioned this issue Sep 16, 2015
Merged
This was referenced Sep 18, 2015
Closed
Closed
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 22, 2015
@mattab mattab changed the title Clicking on Row Evolution, when a segment is set, can fail Row Evolution can fail when a segment is used Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@diosmosis @mattab