Initial test system refactor: introduce annotation driven TestAspect system w/ initial TestWithDatabase aspect #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Pull Request WIP
added 2 commits
September 12, 2015 02:29
… of Piwik test setup/teardown. Create initial annotation based 'test aspect' system and use to store logic for database setup/teardown. Test cases w/ the @testWithDatabase annotation should automatically create a Piwik database (w/o plugins installed).
…estAspect. Includes fix to test aspect detection + makes system test cases work like integration tests (database reset on setUp) for simplicity.
diosmosis
force-pushed
the
test_aspects
branch
from
4de196f
to
df2b2f4
Compare
added 5 commits
September 13, 2015 02:05
…setup + add TestWithPiwikEnvironment aspect (empty for now);
…t integration test case.
… expected only one 'testWith' annotation used per test case. Anootations now include @testWithPiwikDatabase, @testWithPiwikEnvironment, @testWithDatabase, @testWithContainer.
|
I'll close this PR for now as we are in LTS mode for the master branch / Piwik 2. I presume you don't mind @diosmosis :) Currently we don't have resources to continue this feature... we'll use the changes made here later when we work on this again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, more to come.