Show pointer cursor only on sparklines that are linked to a graph #8767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Help wanted
| @@ -42,6 +42,9 @@ window.initializeSparklines = function () { | |||
|
|
|||
| // try to find sparklines and add them clickable behaviour | |||
| graph.parent().find('div.sparkline').each(function () { | |||
|
|
|||
| $(this).addClass('linked'); | |||
There was a problem hiding this comment.
shouldn't this class be added a few lines below, under if (sparklineUrl != "") { ?
There was a problem hiding this comment.
yes, guess that makes a bit more sense :)
|
@mattab if you have nothing else, guess it's ready to merge :) |
mattab
pushed a commit
that referenced
this pull request
Sep 14, 2015
Show pointer cursor only on sparklines that are linked to a graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7084
adds a new class "linked" to sparklines that are bounded to a graph to use it to determine if pointer cursor should be shown on hover.