Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken footer toggling when widgets are/were maximized #8766

Merged
merged 4 commits into from Sep 17, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 11, 2015

Fixes #6734
When maximizing a widget the footer will now automatically be shown. While the widget is maximized the footer cannot be collapsed (until it is closed again)
When the maximized widget is closed the state of the footer (shown or not) is recovered from before maximizing the widget.

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Sep 11, 2015
@sgiehl
Copy link
Member Author

sgiehl commented Sep 13, 2015

Note: The UI changes viewable in the UI-Test failures, seems to be improvements :)
So an update for the UI tests needs to be done after merging

@mattab mattab added this to the 2.15.0 milestone Sep 14, 2015
@diosmosis
Copy link
Member

When I maximise a widget by clicking on the 'all columns' icon, the footer is not expanded:

maximise_bug

Also, clicking on the expand footer icon has no effect.

@sgiehl
Copy link
Member Author

sgiehl commented Sep 15, 2015

I'll have a look

@sgiehl
Copy link
Member Author

sgiehl commented Sep 16, 2015

should be fixed...

diosmosis added a commit that referenced this pull request Sep 17, 2015
Fixes #734, fix broken footer toggling when widgets are/were maximized by forcing footer to be expanded when widgets are maximized.
@diosmosis diosmosis merged commit e742c85 into master Sep 17, 2015
@diosmosis diosmosis deleted the widget_maximise_footer_bug branch September 17, 2015 02:48
diosmosis pushed a commit that referenced this pull request Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants