Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the "Segmented Visitor Log" icon in Custom Variables report #8755

Closed
mattab opened this issue Sep 11, 2015 · 5 comments
Closed

Display the "Segmented Visitor Log" icon in Custom Variables report #8755

mattab opened this issue Sep 11, 2015 · 5 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Sep 11, 2015

Follows up #7212 - requires #6031

Let's display the Segmented Visitor Log icon in Custom Variables, this will be so very awesome feature!
@mattab mattab added this to the 2.15.0 milestone Sep 11, 2015
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Sep 11, 2015
@mattab mattab mentioned this issue Sep 11, 2015
Closed
@diosmosis
Copy link
Member

Added to the top level report in 237f202

It's not possible to add it subtables w/o requesting the top-level report in the subtable API method. This would be a performance hit so I'm moving this to 3.0.

For 3.0, we should make it possible for idSubtables to be the parent row's label, instead of just an integer ID. This would make it possible to get the row label within the subtable method and would increase performance in some cases when it is required to get a subtable by row, w/o having querying the parent table first.

@diosmosis diosmosis modified the milestones: 3.0.0, 2.15.0 Sep 16, 2015
@mattab mattab modified the milestones: 2.15.0, 3.0.0 Sep 18, 2015
@mattab
Copy link
Member Author

mattab commented Sep 18, 2015

Moving back to 2.15.0 - let's close this issue as this is already a new feature, we'll open a new one for the sub-tables icon.

@diosmosis
Copy link
Member

So then should this be closed?

@mattab
Copy link
Member Author

mattab commented Sep 19, 2015

When PR #7212 will be merged, yes

@mattab mattab mentioned this issue Sep 22, 2015
Closed
@mattab
Copy link
Member Author

mattab commented Sep 22, 2015

This enhancement already is useful, nice 👍

Will be followed up & improved further in #8837

@mattab mattab closed this as completed Sep 22, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 13, 2015
@mattab mattab mentioned this issue Oct 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@diosmosis @mattab