Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security, Critical] Piwik uses the MD5 of the password as a valid login token (!!) #8753

Closed
etjossem opened this issue Sep 11, 2015 · 1 comment
Closed

[Security, Critical] Piwik uses the MD5 of the password as a valid login token (!!) #8753

etjossem opened this issue Sep 11, 2015 · 1 comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@etjossem
Copy link

It is possible to pass a username and a password which is the md5 hash of the user's actual password, and Piwik will treat it as valid.

Per docs:

If you want to provide a one-click automatic login to Piwik for your users, you can use the ‘logme’ mechanism, and pass their login & the md5 string of their password in the URL parameters...

If a user ever shares a password between Piwik and another MD5-hashing app, and a bad actor obtains a dump of the other app's hashes, their Piwik account will be compromised (even without any reverse hashing).
@etjossem etjossem mentioned this issue Sep 11, 2015
Closed
@mattab
Copy link
Member

mattab commented Sep 14, 2015

Thanks @etjossem for the report.

Piwik works in this way by design so far. to resolve this issue properly is included in #5728 where we will improve the hashing algorithm and also provide a more secure logme mechanism.

@mattab mattab closed this as completed Sep 14, 2015
@mattab mattab added duplicate For issues that already existed in our issue tracker and were reported previously. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. labels Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @etjossem