Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor icons alignment issues #8748

Closed
mattab opened this issue Sep 10, 2015 · 9 comments
Closed

Minor icons alignment issues #8748

mattab opened this issue Sep 10, 2015 · 9 comments
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 10, 2015

Noticed couple small issues on the demo after upgrading it to beta5:

Issue 1

  • Expected "Outlink icon" to be vertically aligned with the URL.
  • Got: outlink icon appears below the blue text

alignment issue

Issue 2

  • Expected: Search and outlink icon vertically aligned with text on the right
  • Got:
    • Both icons are missing right margin (text is too close to icon)
    • The Search icon is mis-aligned: appears too low compared to the search term

icon alignment issues

@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 10, 2015
@mattab mattab added this to the 2.15.0 milestone Sep 10, 2015
@diosmosis diosmosis self-assigned this Sep 18, 2015
@tsteur tsteur assigned tsteur and unassigned diosmosis Oct 2, 2015
mattab added a commit that referenced this issue Oct 4, 2015
@mattab mattab reopened this Oct 4, 2015
@mattab
Copy link
Member Author

mattab commented Oct 4, 2015

Sub-table icons are still a bit mis-aligned, see screenshot:

icons aligned

Icon should be slightly higher (veritically aligned with text)

@tsteur
Copy link
Member

tsteur commented Oct 5, 2015

which browser is that? Is zoom activated? Tried to reproduce in firefox and chrome

@mattab
Copy link
Member Author

mattab commented Oct 5, 2015

Can reproduce this issue on both Firefox and Chromium on Ubuntu, on demo2 + local dev Piwik. The sub-table icons are displayed too much to the bottom, expected: icons vertically aligned. can you reproduce it?

@tsteur
Copy link
Member

tsteur commented Oct 5, 2015

I couldn't. Are you sure there is no zoom or so active?

@mattab
Copy link
Member Author

mattab commented Oct 5, 2015

Strange, yes there is no zoom, see screenshot below:

icons misaligned

@tsteur
Copy link
Member

tsteur commented Oct 6, 2015

OK in master I can reproduce it, was testing in the branch. It's weird as there was this merge: 0dc0e31 of #8817 but the code is not in master. History also doesn't show any existence. Was there a push --force or so?

@mattab
Copy link
Member Author

mattab commented Oct 6, 2015

Was there a push --force or so?

history | grep force has no result and I don't use this anyway. It's kinda scary that we can lose commits in this way... I'm wondering if there is a way to detect such "lost" commits...

@mattab
Copy link
Member Author

mattab commented Oct 6, 2015

FYI: enabled the "protected branch" feature for our master branch on piwik/piwik

Hopefully this will prevent such issue in future?

@tsteur
Copy link
Member

tsteur commented Oct 7, 2015

issued another PR waiting for UI tests then we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

3 participants