When detecting campaign info in Referrers check _rcn and _rck query parameters. #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rck query parameters.
diosmosis
added
not-in-changelog
mattab
changed the title
|
LGTM 👍 |
mattab
pushed a commit
that referenced
this pull request
Sep 11, 2015
When detecting campaign info in Referrers check _rcn and _rck query parameters.
|
Note: this regressed tracking campaigns in some way, see the fix in: #9363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, in Referrers dimensions, use _rcn/_rck values if they are present as campaign name/keyword.
@mattab Can you review? I am not too familiar w/ the way campaign tracking is supposed to work.
Fixes #8630