Correctly parse all URL schemes in UrlHelper::isLookLikeUrl(). #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
|
There are two integration tests failing now. Maybe we should check where the |
…g + fix SitesManager/ApiTest.
|
Fixed the failing tests. Will fix other failures if they show up.
We should probably replace this w/ a utility library in 3.0. For LTS, big changes like this would be counterproductive. |
|
Failing UI test is a random failure |
| page.evaluate(function () { | ||
| // cannot use sendKeys since quickform does not use placeholder attribute |
There was a problem hiding this comment.
@diosmosis curious why it's still above page.sendKeys('input[name=siteName]', 'Serenity'); if we cannot use sendKeys?
There was a problem hiding this comment.
Forgot to delete it :)
|
LGTM and works! |
mattab
pushed a commit
that referenced
this pull request
Sep 11, 2015
Correctly parse all URL schemes in UrlHelper::isLookLikeUrl().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Changed the regex to match all allowed schemes (as per the RFC: https://tools.ietf.org/html/rfc3986#section-3.1).
Fixes #8722