Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround chrome bug: in enriched headline use <div> w/ ng-transclude #8743

Merged
merged 1 commit into from Sep 9, 2015

Conversation

diosmosis
Copy link
Member

Chrome does not correctly apply CSS to nested <span> elements which causes a problem for enriched headlines which uses ng-transclude on <span>. Using a <div> w/ display:inline-block fixes this.

Fixes #8740

…es not correctly apply CSS to outer <span>s.
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 9, 2015
@diosmosis diosmosis added this to the 2.15.0 milestone Sep 9, 2015
@sgiehl
Copy link
Member

sgiehl commented Sep 9, 2015

Just tested the fix. Works 👍

sgiehl added a commit that referenced this pull request Sep 9, 2015
Workaround chrome bug: in enriched headline use <div> w/ ng-transclude
@sgiehl sgiehl merged commit 885776a into master Sep 9, 2015
@sgiehl sgiehl deleted the 8740_enriched_headline_workaround branch September 9, 2015 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants