Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8734 Bad filesystem detection (NFS) #8737

Merged
merged 1 commit into from Sep 8, 2015
Merged

Conversation

nuxwin
Copy link
Contributor

@nuxwin nuxwin commented Sep 8, 2015

No description provided.

@nuxwin
Copy link
Contributor Author

nuxwin commented Sep 8, 2015

@mattab

The following check which was previously added in master:

$commandFailed = (false !== strpos($output, "no file systems processed"));

was not sufficient. Think about LANG environment variable which can be different.

@tsteur
Copy link
Member

tsteur commented Sep 8, 2015

Did only adding the trim() fix the issue?

@nuxwin
Copy link
Contributor Author

nuxwin commented Sep 8, 2015

@tsteur

Yes ;)

You could even remove the

$commandFailed = (false !== strpos($output, "no file systems processed"));

part which is not required with the trim() fix ;)

@tsteur
Copy link
Member

tsteur commented Sep 8, 2015

Nice, thx

tsteur added a commit that referenced this pull request Sep 8, 2015
#8734 Bad filesystem detection (NFS)
@tsteur tsteur merged commit 4e57489 into matomo-org:master Sep 8, 2015
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 8, 2015
@tsteur tsteur added this to the 2.15.0 milestone Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants