Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in System tests, <idsubdatatable> sometimes changes value with no apparent reason #8727

Closed
mattab opened this issue Sep 8, 2015 · 1 comment
Closed

in System tests, <idsubdatatable> sometimes changes value with no apparent reason #8727

mattab opened this issue Sep 8, 2015 · 1 comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Sep 8, 2015

In System tests, it seems that sometimes the <idsubdatatable> increases value.

Here is test output:

1) Piwik\Tests\System\TwoVisitorsTwoWebsitesDifferentDaysTest::testApi with data set #5 ('API.getProcessedReport', array(1, '2010-01-03 11:22:33', array('day'), true, 'Referrers', 'getWebsites', '_Referrers.getWebsites_firstSite_lastN'))

Piwik\Tests\System\TwoVisitorsTwoWebsitesDifferentDaysTest: Differences with expected in '/home/travis/build/piwik/piwik/tests/PHPUnit/Framework/TestCase/../../System/processed/test_TwoVisitors_twoWebsites_differentDays_Referrers.getWebsites_firstSite_lastN__API.getProcessedReport_day.xml'
Failed asserting that two DOM documents are equal.
--- Expected
+++ Actual
@@ @@
         <segment>referrerName==referrer.com</segment>
-        <idsubdatatable>17183</idsubdatatable>
+        <idsubdatatable>17215</idsubdatatable>
       </row>
     </result>
     <result prettyDate="Monday 4 January 2010">
       <row>
         <segment>referrerName==referrer.com</segment>
-        <idsubdatatable>17185</idsubdatatable>
+        <idsubdatatable>17217</idsubdatatable>

Notes

What do you think could cause this test failure?
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 8, 2015
mattab added a commit that referenced this issue Sep 8, 2015
@mattab
Fix system tests refs #8727
7776559
@mattab mattab added this to the 2.15.1 milestone Sep 11, 2015
mattab added a commit that referenced this issue Sep 14, 2015
@mattab
Refs #8727 Changing order of tests to have a consistent <idsubdatatab…
2b07451 
…le> counter over time
@mattab
Copy link
Member Author

mattab commented Sep 14, 2015

I'll tentatively mark this one as closed as I tried to fix it in: 2b07451

if issue re-occurs next week or later, let's reopen this issue

@mattab mattab closed this as completed Sep 14, 2015
@mattab mattab modified the milestones: 2.15.1, 2.15.0 Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
1 participant
@mattab