New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS gives all IP's 0.0.0.0 #8721
Comments
Can you have a look at #8030 (comment) and send us the output? That'd be really helpful |
Output:
config.ini.php proxy_client_headers:
|
@Firesphere I just wanted to have a look but I'm wondering where exactly you get origin IP |
Do you have anything configured for |
@Firesphere do you maybe have answers to our couple questions above? |
@mattab Sorry! I've been a bit busy (I'm in the process of moving from the Netherlands to New Zealand, takes up a lot of time and thoughts) The IP is (according to my breakpoint) in the IP class itself actually, where there's the default 0.0.0.0, and the headers are then looped. I do not have anything specifically configured for proxy_ips, as far as I know. I've only altered/tested/tried with the proxy_client_headers |
OK we should try to reproduce, only had a look at the code so far and that looked good. @mattab do you mind setting a milestone? Not sure what to set |
done: |
Note: our FAQ about this topic is https://piwik.org/faq/troubleshooting/faq_17710/ |
@Firesphere do you mind adding this line https://github.com/piwik/piwik/pull/9099/files#diff-a1ef1fb37277203311f5eed60b826653R119 to |
Sorry for the late reply, but it seems this solves the no-ip issue indeed. I've been testing a bit, but have not yet encountered any 0.0.0.0 errors anymore. (Or any other replacement IP for that matter) |
Nice to hear & good find @tsteur 👍 Let's also add a test for this use case |
There's a test in the PR |
Nice! this issue will be fixed in 2.15.1 |
All my non-SSL connections work fine, but https gives 0.0.0.0 as origin IP. Doesn't matter what I try. I've been through the FAQ a dozen times, but no result :(
The text was updated successfully, but these errors were encountered: