Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with isLookLikeUrl in core/UrlHelper #8720

Closed
haseebeqx opened this issue Sep 6, 2015 · 1 comment
Closed

issue with isLookLikeUrl in core/UrlHelper #8720

haseebeqx opened this issue Sep 6, 2015 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@haseebeqx
Copy link
Contributor

this is a simple issue.
this function is not working as intented.
it can be bypassed with strings like http://..
instead of regex i recommend using php default url filter which is much better filter_var($url,FILTER_VALIDATE_URL)

@haseebeqx
Copy link
Contributor Author

not important.
found some case it is needed

@sgiehl sgiehl added the answered For when a question was asked and we referred to forum or answered it. label Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

2 participants