New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
started working on PHP 7 support #8706
Conversation
@@ -93,8 +103,8 @@ before_install: | |||
install: | |||
- git fetch -q | |||
|
|||
- export GENERATE_TRAVIS_YML_COMMAND="php ./tests/travis/generator/main.php generate:travis-yml --core --verbose" | |||
- '[[ "$TRAVIS_JOB_NUMBER" != *.1 || "$TRAVIS_PULL_REQUEST" != "false" ]] || ./tests/travis/autoupdate_travis_yml.sh' | |||
# - export GENERATE_TRAVIS_YML_COMMAND="php ./tests/travis/generator/main.php generate:travis-yml --core --verbose" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can enable it again but this means we need to update travis to maybe also run tests for plugins on PHP 7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could regenerate the core .travis.yml w/ --php-versions=7,5.6,5.3.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to merge matomo-org/travis-scripts#9 soon. That should be fine right? Or will it trigger to many auto updates etc? @diosmosis
I've had a look at the changes... Did you try to (un)install / (de)activate plugins using php7? That doesn't work for me. I tried to figure out why, seems the config is not updated... small note: when using php 5.5.20 with this branch handling the plugins works |
I haven't tested that yet. Neither the installation (although we have tests for that). It's just a start so far, it will be much more work I think to make it actually compatible and will need much more testing. It's just a start to make the test run and to fix some things that were covered by tests |
I can confirm activate / deactivate doesn't work. I tried to debug but I couldn't use the interactive debugger so it was hard to debug. I really do not understand the code in |
Activating / deactivating plugin should work now |
I can confirm that (de)activating plugins works with the latest changes 👍 |
Targeting 2.15.0 - if we don't merge it for 2.15.0 we should in a separate PR include the |
Started looking at this, but won't be able to finish a review for a day or two. |
Fyi: the system test failure should be fixed after a rebase. LGTM |
BTW: The method name Config::forceSave is kinda wrong as it does not force anything, it saves only if there is a change
started working on PHP 7 support
just a question on this: => will 2.15 work fine on php 7.0? If yes, the speed gains should be promoted greatly (if there are any) On other platforms, php 7.0 is a huge step: |
It's not fully compatible yet. I presume that's why it is not mentioned there. It might work fun but there could be some problems. I reckon there will be most likely a minor update for PHP 7 once it is released in a few weeks. |
this issue is marked as done in #8689 |
refs #8689
This is only partial PHP 7 support. More fixes will be needed.
There is a big blocker re
usort
. It will be hard to make system and UI tests working under PHP5.X and PHP 7.X see #8689 (comment) . Ideas?I also created matomo-org/component-decompress#4
I believe once we fixed the sort problem and the decompress we will have it almost done