Next round: PSR-2 + php-cs-fixer #8704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2015
Closed
|
Hi @ThaDafinser I think (if i'm not mistaken) that if we want to fix the code (IMO it's nice to have!), we should do it rather quickly or we may risk a merge-hell with 3.0.0 and LTS branch. @tsteur any thought on this maybe? |
|
yes would be good to do after merging 3.0 to master! I already had yesterday some troubles re some line ending changes when I merged master => 3.0 |
|
Just to be sure, do you suggest we should do the PSR fix only after 3.0.0 has become |
|
yes @mattab you are right: ASAP ...otherwise merging wont be fun, but with this change it will be much easier! I just let it open for you guys, since you can choose a good moment - e.g. most (large) PRs are merged already.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello together,
i've done now really the smallest part to finally add php-cs-fixer to piwik.
How to install global: https://github.com/FriendsOfPHP/PHP-CS-Fixer#globally-composer
I extra left out following things:
Include it for all php folders - Why not?
You guys should activate it, when you think its a good time that not all PRs need to go through a merge "hell". Just change the exclude/include part in .php-cs-fixer
Do not add it to the build system and even not composer
As long as Piwik still support PHP 5.3.3 this is not possible. When Piwik at least requires PHP 5.3.6 we can add it then.
#7731
#8047
#7186
#7955
@mattab i think it would be a good idea to add this also to 2.15, since then merging/backporting from 3.x branch down would be easier?
My idea is to execute this by hand first from time to time and add more and more folder, until we have all. Then when also PHP 5.3.6 is required we add it to the build system