Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide various release channels, eg let user choose between latest stable and LTS version #8688

Merged
merged 2 commits into from Sep 22, 2015
Merged

Provide various release channels, eg let user choose between latest stable and LTS version #8688

merged 2 commits into from Sep 22, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 1, 2015

DO NOT MERGE

refs #8549

Here is a screenshot: http://builds-artifacts.piwik.org/piwik/piwik/8549/15097/UIIntegrationTest_admin_settings_general

  • Test agains once changes in api.piwik.org are made
  • After merge update docs that mention [Debug] allow_upgrades_to_beta afterwards as it was changed to [General]release_channel

Plugins can now very easily provide their own custom release channels but we're not making it a public API as it won't be needed for now. The API might change once there is an actual use case for it. Eg right now they require that the latest available version number is checked via HTTP and that this API returns only a version number etc (not eg a JSON etc). Such things could be changed if it ever becomes API.

Possible use cases for custom release channels in the future:

  • Someone wants to provide a channel for nightly builds
  • Someone wants to provide an intranet server that serves updates as the actual Piwik instances might not be connected to the Internet
  • Someone wants to provide custom updates for users/clients. Eg we could have a central server and a client's Piwik connects to this central server where we have a prepackaged update for them including custom Plugins etc.
  • It will be easily possible to define new release channels for Piwik 4.X, Piwik 5.X, ...

Such things were kinda possible before but much harder to do.

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 1, 2015
@tsteur tsteur added this to the 2.15.0 milestone Sep 1, 2015
@tsteur tsteur mentioned this pull request Sep 1, 2015
Closed
2 tasks
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Sep 2, 2015
@tsteur
Copy link
Member Author

tsteur commented Sep 2, 2015

I added label needs review but we should not merge it yet as we need to wait for changes in api.piwik.org to be done

@diosmosis
Copy link
Member

Code looks good, and +1000 for the concept.

@tsteur
Copy link
Member Author

tsteur commented Sep 21, 2015

@mattab what's the current status of api.piwik.org? Are they made? Can we merge this one?

@mattab
Copy link
Member

mattab commented Sep 22, 2015

@tsteur Changes are made, and deployed, to api.piwik.org

mattab pushed a commit to matomo-org/matomo-package that referenced this pull request Sep 22, 2015
Also deploy LATEST_BETA to api.piwik.org
17ed866 
refs matomo-org/matomo#8688
@mattab mattab mentioned this pull request Sep 22, 2015
Merged
@mattab
Copy link
Member

mattab commented Sep 22, 2015

For reference, API URLs for channels are:

@mattab mattab mentioned this pull request Sep 22, 2015
Closed
8 tasks
@mattab
Copy link
Member

mattab commented Sep 22, 2015

@tsteur when merging this to 3.X branch, you can assume we'll have the 3.X LTS channel. so maybe we just replace 2.X by 3.X in the UI in 3.0.0 branch?
and when merging it, feel free to issue PR in api.piwik.org to add the new 3x_ config settings...

@tsteur
Copy link
Member Author

tsteur commented Sep 22, 2015

so maybe we just replace 2.X by 3.X in the UI in 3.0.0 branch?

I think we might just add a 3.X_beta and declare it as experimental or actually I think we'll think about it as soon as we actually release a beta :)

@mattab
Copy link
Member

mattab commented Sep 22, 2015

or actually I think we'll think about it as soon as we actually release a beta :)

Ok feel free to post any thought in #8836

@mattab
Copy link
Member

mattab commented Sep 22, 2015

After merge update docs that mention [Debug] allow_upgrades_to_beta afterwards as it was changed to [General]release_channel

All good it wasnt documented anywhere

mattab pushed a commit that referenced this pull request Sep 22, 2015
Merge pull request #8688 from piwik/8549
31d9ddc 
Provide various release channels, eg let user choose between latest stable and LTS version
@mattab mattab merged commit 31d9ddc into master Sep 22, 2015
@mattab mattab deleted the 8549 branch September 22, 2015 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @diosmosis @mattab