Run UI tests in two different jobs #8684
Conversation
apply new naming
tsteur
added
not-in-changelog
|
this is a great win, what a good idea! Re: Builds artifacts does it work smoothly when the build is split across 2 jobs (ie. can we still see all screenshots diffs in one page on builds-artifacts) this will close #8222 beautifully for sure |
|
I tried it with a failure in first run and with a failure in second run and worked. Haven't tested with an error in both builds but so far screenshots are always added to that directory on builds-artifacts I think so it should work |
| @@ -1 +1 @@ | |||
| Subproject commit f62fc4fe97a88aa11e495abda384f142b38fd580 | |||
| Subproject commit b7a9cd1a1755b9f500ac111713ce07bb983c12e7 | |||
There was a problem hiding this comment.
Should the submodule be different? Other than this, looks good to merge.
There was a problem hiding this comment.
Yes as it points to new travis version that recognizes the UITEST_EXTRA_OPTIONS variable
Run UI tests in two different jobs
|
Actually, I noticed files get deleted every time we upload new artifacts. This was changed recently in https://github.com/piwik/ui-tests-viewer/commit/a0b03de6f9257393c9a511723c661ebeb14795c1 and will maybe simply undo that delete directory to fix it for now |
|
Fixed |
refs #8222 and see #8222 (comment)
Example run: https://travis-ci.org/piwik/piwik/builds/78185419
Instead of having 1 job that takes about 35-45 minutes we now have 2 jobs that take about 17-24minutes each. As mentioned in the issue we could also split it into three jobs but then other commits take longer to start maybe as we need more jobs. We can see how it goes and still change things later.
Not sure if we can close #8222 afterwards for now? I'd close I think as goal of
the UI tests should run ideally in less than 20 or 25 minutesis satisfied. They are even faster thenAllTestsjob